Skip to content

Conversation

HamadUllah16
Copy link
Contributor

@HamadUllah16 HamadUllah16 commented Sep 5, 2025

Fix: 68521 Updating outdated with-msw example

The with-msw is outdated and doesn't work with the latest msw version.

What?

The with-msw example is outdated and does not work with the latest msw version.

Why?

  • msw now uses http instead of rest and the outdated implementation does not work with the latest version anymore.
  • the client-side worker is now imported through msw/browser.

How?

  • replaced all usage of rest with http to align with MSW's new API.
  • updated the worker import to use msw/browser as per the new structure.

Media

localhost_3000.-.Google.Chrome.2025-05-08.09-50-04.mp4

@ijjk ijjk added the examples Issue was opened via the examples template. label Sep 5, 2025
@ijjk
Copy link
Member

ijjk commented Sep 5, 2025

Allow CI Workflow Run

  • approve CI run for commit: d8a2ad2

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@HamadUllah16
Copy link
Contributor Author

Hi @lukesandberg @ijjk, Would you please review this PR? It was long pending and outdated and I had to recreate a new one with cleaner implementation. Appreciated!

@icyJoseph
Copy link
Contributor

Hi, thanks for the PR, I'll take a quick look :)

@HamadUllah16
Copy link
Contributor Author

Hi @icyJoseph, Thanks for checking this out. Any update on this?

@icyJoseph icyJoseph merged commit 85a2a02 into vercel:canary Sep 8, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

with-msw example doesn't work.
3 participants