URL forwarding removes query string

[C0pyR1ght]

When navigating tosearch.html Serve forwards the request to /search.
so far so good. But query-strings at the end of an URL are removed while forwarding:

search.html?s=hello -> /search

This is not a behavior I would expect in normal operation

[oshi97]

Any updates on this issue?

[mvolkmann]

This is a huge issue for me. To get around this I used http-server instead of serve which does not lose query parameters.

[C0pyR1ght]

@mvolkmann yepp.. Makes serve unusable for any project with query strings.

This seems to be an issue of serve-handler which is the serve core. Even found an old issue from 2019 about this vercel/serve-handler#97 and also a PR that fixes it vercel/serve-handler#144. But sadly no one cares

[warren-bank]

shameless self-promotion alert:
this feature is fixed in my @warren-bank/serve fork of serve

[canvaspixels]

@warren-bank I get this when I install it, could be because i'm using nvm.

npm i -g @warren-bank/serve
npm ERR! code 1
npm ERR! path /$USER/.nvm/versions/node/v16.13.2/lib/node_modules/@warren-bank/serve
npm ERR! command failed
npm ERR! command sh -c npm install ./lib/serve-handler && npm install ./lib/serve
npm ERR! added 45 packages, and audited 48 packages in 8s
npm ERR!
npm ERR! 12 packages are looking for funding
npm ERR!   run `npm fund` for details
npm ERR!
npm ERR! found 0 vulnerabilities
npm ERR! npm WARN cleanup Failed to remove some directories [
npm ERR! npm WARN cleanup   [
npm ERR! npm WARN cleanup     undefined,
npm ERR! npm WARN cleanup     AssertionError [ERR_ASSERTION]: rimraf: missing path
npm ERR! npm WARN cleanup         at rimraf (/$USER/.nvm/versions/node/v16.13.2/lib/node_modules/npm/node_modules/rimraf/rimraf.js:54:3)

[warren-bank]

@canvaspixels

1. since neither serve nor my fork use rimraf (to delete directories in npm scripts)..
   probably an issue is with your environment:
   • either (unlikely) a bug in nvm
   • or (more likely) you need elevated permissions to run install on your system
2. do you get the same error when you install serve (upstream)
3. if not.. and this error message only occurs for my fork.. then:
   • please create an issue in my repo..
     so we don't hijack this thread with an off-topic conversation

update:

• you're right.. I'm wrong
• xref: to issue
• problem on posix w/ symbolic link to libraries.. will fix ASAP
• sorry! ..but thanks for reporting

final update:

• sorry everybody for the unwanted noise
• this issue w/ global npm install is now fixed in v130002.16.0
  • which has been pushed to npm

[bramus]

+1 on this. I think serve should preserve the querystring when redirecting, like it does with the location’s hash.

[morganney]

Just use http-server instead.