Skip to content

ci: Fix leaky tests #11081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthonyshew merged 5 commits into from
Nov 10, 2025
Merged

ci: Fix leaky tests #11081

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7ca33ee
ci: fix leaky test
anthonyshew Nov 10, 2025
ce243c9
fmt
anthonyshew Nov 10, 2025
6e82f19
Fix: The `handles_kill_dead_server` test spawns a process without `.k…
vercel[bot] Nov 10, 2025
6370a68
Fix via Vade
vercel[bot] Nov 10, 2025
5799159
Merge branch 'main' into shew/89bde
anthonyshew Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/turborepo-lib/src/daemon/connector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ impl DaemonConnector {
return {
debug!("connected in {}µs", time.elapsed().as_micros());
Ok(client.with_connect_settings(self))
}
};
}
Err(DaemonError::VersionMismatch(_)) if self.can_kill_server => {
self.kill_live_server(client, pid).await?
Expand Down Expand Up @@ -524,6 +524,7 @@ mod test {
.stderr(Stdio::null())
.arg("-e")
.arg("setInterval(() => {}, 1000)")
.kill_on_drop(true)
.spawn()
.unwrap();

Expand Down
Loading