fix: Improve behavior for OOM-killed tasks#11477
Merged
Merged
Conversation
- Add Windows OOM detection for NT status codes (STATUS_NO_MEMORY, STATUS_STACK_OVERFLOW, STATUS_COMMITMENT_LIMIT) - Add Unix OOM detection for SIGKILL (exit code 137) - Handle ChildExit::Finished(None), ChildExit::Failed, and ChildExit::KilledExternal as task failures with proper error messages - Remove ExternalKill error variant in favor of proper task failure handling - Provide clearer error messages indicating likely OOM conditions
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
anthonyshew
commented
Jan 15, 2026
anthonyshew
changed the title
anthonyshew
commented
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Behavioral change: Previously
ChildExit::KilledExternal,ChildExit::Finished(None), andChildExit::Failedreturned internal errors (InternalError::ExternalKill,InternalError::UnknownChildExit). Now they're handled as normal task failures with proper exit codes, error logging, and respect for--continueflags.Changes:
KilledExternal→ task failure with exit code 137 (SIGKILL convention)Finished(None)/Failed→ task failure with exit code 1InternalError::ExternalKillvariantThis means externally-killed tasks now behave consistently with tasks that exit non-zero rather than causing internal errors.