fix: Add explicit secrets declarations to release workflow_call trigger#11619
Merged
anthonyshew merged 1 commit intomainfrom Feb 1, 2026
Merged
fix: Add explicit secrets declarations to release workflow_call trigger#11619anthonyshew merged 1 commit intomainfrom
anthonyshew merged 1 commit intomainfrom
Conversation
When called via workflow_call, the release workflow requires NPM_TOKEN, TURBO_TOKEN, and DOCS_ALIAS_FAILURE_SLACK_WEBHOOK_URL secrets. Making these explicit improves contract clarity and enables early validation when secrets are missing.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ghost
added
the
anthonyshew
added a commit
that referenced
this pull request
Feb 1, 2026
## Summary Updates the canary workflow to pass secrets explicitly to the release workflow, fixing the validation error introduced by the explicit `secrets` declarations in #11619. ## Why The release workflow now declares required secrets with `required: true`. Using `secrets: inherit` doesn't satisfy this validation - secrets must be passed explicitly. This is also a security improvement: the canary workflow now only passes the 3 required secrets rather than inheriting all repository secrets.
anthonyshew
pushed a commit
that referenced
this pull request
Feb 1, 2026
## Canary Release Versioned docs: https://v2-8-2-canary-3.turborepo.dev ### Included Changes - 469f9dd - fix: Upgrade ts-jest to 29.4.6 to fix brace-expansion ReDoS vulnerabilities (#11623) (#11623) - af6aef8 - fix: Upgrade inquirer to 8.2.7 to fix tmp vulnerability (#11622) (#11622) - 73e1a65 - fix: Consolidate canary releases into release workflow for npm trusted publishing (#11624) (#11624) - e192b8e - fix: Upgrade diff to fix DoS vulnerabilities (#11621) (#11621) - c79e54e - fix: Upgrade rehype packages to fix mdast-util-to-hast vulnerability (#11616) (#11616) - aceb210 - fix: Pass secrets explicitly in canary workflow (#11620) (#11620) - d6ca8cd - fix: Add explicit secrets declarations to release workflow_call trigger (#11619) (#11619) - a0c22ca - ci: Automated canary release pipeline (#11618) (#11618) --- Release PR for turborepo v2.8.2-canary.3 Co-authored-by: Turbobot <turbobot@vercel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secretsdeclarations to theworkflow_calltrigger in the release workflowNPM_TOKEN,TURBO_TOKEN,DOCS_ALIAS_FAILURE_SLACK_WEBHOOK_URLWhy
When the release workflow is called via
workflow_call(e.g., fromturborepo-canary.yml), secrets must be explicitly passed or inherited. Making these requirements explicit:Testing