fix: Treat npm: alias dependencies as external, not workspace references#12061
Merged
Conversation
When a dependency uses the npm: alias syntax (e.g. "buffer": "npm:buffer@6.0.3"), turborepo incorrectly resolved it to a workspace of the same name. The alias format npm:<pkg>@<version> explicitly targets the npm registry, so it should never match a workspace package. Closes #8989
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
anthonyshew
changed the title
npm: alias dependencies as external, not workspace references
Contributor
Coverage Report
|
github-actions Bot
added a commit
that referenced
this pull request
Feb 28, 2026
## Release v2.8.13-canary.8 Versioned docs: https://v2-8-13-canary-8.turborepo.dev ### Changes - fix: Exclude peer dependencies from workspace external dep resolution (#12050) (`3a75547`) - test: Port all 15 workspace-configs prysk tests to Rust (#12058) (`55442be`) - release(turborepo): 2.8.13-canary.7 (#12060) (`495afdc`) - perf: Stream file contents during hashing to lower memory usage (#12059) (`f03cdce`) - fix: Treat `npm: alias` dependencies as external, not workspace references (#12061) (`b179cb8`) - test: Port 18 more prysk tests to Rust (other/ + lockfile-aware-caching/) (#12062) (`7887af2`) --------- Co-authored-by: Turbobot <turbobot@vercel.com>
github-actions Bot
added a commit
that referenced
this pull request
Mar 2, 2026
## Release v2.8.13-canary.9 Versioned docs: https://v2-8-13-canary-9.turborepo.dev ### Changes - fix: Treat `npm: alias` dependencies as external, not workspace references (#12061) (`b179cb8`) - test: Port 18 more prysk tests to Rust (other/ + lockfile-aware-caching/) (#12062) (`7887af2`) - release(turborepo): 2.8.13-canary.8 (#12063) (`2a5522a`) - fix: Preserve file: protocol entries in pruned yarn v1 lockfile (#12064) (`ae5c1a1`) - perf: Use stack-allocated OidHash in FileHashes and skip expanded hashes on normal runs (#12065) (`677b248`) - test: Port all 8 find-turbo prysk tests to Rust (#12066) (`f827fca`) - fix: Support pnpm per-workspace lockfiles in turbo prune (#12067) (`23d047d`) - test: Port final 2 prysk tests to Rust (100% complete) (#12068) (`6d7e057`) - fix: Resolve Berry prune failure when resolutions contain patch overrides (#12069) (`6fe3c5e`) - test: Add lockfile fixture for yarn berry resolution pruning (issue #2791) (#12071) (`6cc1654`) - chore: Remove prysk test framework entirely (#12070) (`ed2d05a`) - refactor: Clean up test infrastructure and eliminate duplication (#12072) (`338911d`) - fix: Retain injected workspace package entries during pnpm lockfile pruning (#12073) (`acbe869`) - ci: Exclude turborepo-lsp and turborepo-schema-gen from test builds (#12075) (`4ce12e2`) - refactor: Clean up test infrastructure + improve test quality (#12074) (`4571f2b`) - ci: Remove redundant cargo build from coverage job (#12077) (`3c9bbe2`) - perf: Speed up lockfile test suite (#12078) (`20024df`) - ci: Remove integration test serialization (#12079) (`24d7c02`) - fix: Preserve `file:` and `link:` protocol entries in pruned bun lockfile (#12076) (`2635d9a`) - fix: Stop running unnecessary npm install in engines tests (#12081) (`24e4905`) - test: Add lockfile fixture for pnpm v9 injected workspace deps (issue #8243) (#12082) (`4d4929b`) - fix: Filter orphaned Yarn packageExtensions entries during lockfile pruning (#12084) (`68eb223`) - fix: Align experimentalObservability on object maps rather than arrays (#12089) (`9b9d1e4`) - examples: Upgrade with-react-native-web example to use latest versions (#12085) (`980ca43`) - fix: duplicate /signup? in Vercel URL (#12088) (`e865b51`) - ci: Deduplicate Rust test compilation with nextest archive (#12083) (`962cf39`) - fix: Prevent yarn integration tests from hanging on corepack prompts (#12090) (`29b0da7`) - fix: Prevent turbo dev from hanging when daemon file watching fails (#12091) (`b0d2f62`) - ci: Skip pnpm install for Rust test jobs (#12092) (`ebd137f`) - perf: Optimize npm lockfile parser (#12093) (`e4b4a66`) - chore: Trim unused dependency features for faster compilation (#12094) (`03b79e0`) - fix: Prevent lockfile-aware yarn test from hanging on corepack downloads (#12095) (`bf516e4`) - fix: Exclude turborepo-repository from JS smoke test in release workflow (#12097) (`fecc400`) --------- Co-authored-by: Turbobot <turbobot@vercel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8989
npm:alias syntax (e.g."buffer": "npm:buffer@6.0.3"), turborepo incorrectly resolved it to a workspace of the same name instead of the npm registry package. Thenpm:<pkg>@<version>format explicitly targets the npm registry and should never match a workspace.Root cause
DependencyVersion::new("npm:buffer@6.0.3")splits intoprotocol="npm"andversion="buffer@6.0.3". Sincenpmis special-cased to not be treated as external (for transparent workspace support), the code falls through to semver comparison."buffer@6.0.3"fails to parse as a semver range, and the backwards-compatibility fallback treats parse failures as internal matches.Fix
Added
is_npm_alias()to detect thenpm:<pkg>@<version>alias format (including scoped packages likenpm:@scope/pkg@^1.0.0). Aliased npm dependencies are always treated as external since they explicitly target the npm registry. This is distinct from plainnpm:^1.0.0ranges which still participate in transparent workspace resolution.Testing
To understand the fix, the
test_is_npm_aliasandtest_matches_workspace_package("handles npm alias with matching workspace name") test cases indep_splitter.rsare the most relevant. A berry lockfile test (test_npm_alias_does_not_resolve_to_workspace) verifies the lockfile resolution and pruning paths. Aberry-npm-aliasfixture was added tolockfile-tests/fixtures/reproducing the exact scenario from the issue.