Skip to content

fix: Remove Unix parent death watchdogs #12699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthonyshew merged 2 commits into from
May 4, 2026
Merged

fix: Remove Unix parent death watchdogs #12699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8815d46
fix: Remove Unix parent death watchdogs
anthonyshew May 2, 2026
344ee26
fix: Repair watchdog removal CI
anthonyshew May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion crates/turborepo-process/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ Process management for running task commands. Spawns and manages child processes

- PTY support is inferred from terminal attachment on non-Windows platforms
- On Windows, graceful shutdown sends KILL immediately (no SIGINT equivalent)
- On Unix, processes are spawned in their own process group via `setsid()` to enable group signaling
- On Unix, processes are spawned in their own process group to enable group signaling
- `stop_tasks()` allows selective process termination without closing the manager (used for watch mode restarts)
- Closing stdin on Windows with ConPTY immediately terminates the process, so stdin is kept open in that case
- Graceful shutdown should be handled internally by tracking spawned process groups
until they exit; parent-death cleanup after Turbo crashes or is killed is a
separate concern
Loading
Loading