Skip to content

fix: Handle JSON decoration visitor depth#12752

Merged
anthonyshew merged 2 commits into
mainfrom
shew/8327b
May 8, 2026
Merged

fix: Handle JSON decoration visitor depth#12752
anthonyshew merged 2 commits into
mainfrom
shew/8327b

Conversation

@anthonyshew
Copy link
Copy Markdown
Contributor

@anthonyshew anthonyshew commented May 8, 2026

Summary

  • Prevents VS Code turbo.json decorations from failing on valid JSON objects by correcting visitor depth tracking.
  • Decorates the modern top-level tasks key, with legacy pipeline fallback for older configs.
  • Adds regression coverage for top-level tasks, legacy pipeline, nested keys, and configs containing both keys.

Fixes TURBO-5502

@anthonyshew anthonyshew requested a review from a team as a code owner May 8, 2026 03:27
@anthonyshew anthonyshew requested review from tknickman and removed request for a team May 8, 2026 03:27
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
examples-basic-web Ready Ready Preview, Comment, Open in v0 May 8, 2026 3:32am
examples-designsystem-docs Ready Ready Preview, Comment, Open in v0 May 8, 2026 3:32am
examples-gatsby-web Ready Ready Preview, Comment, Open in v0 May 8, 2026 3:32am
examples-kitchensink-blog Ready Ready Preview, Comment, Open in v0 May 8, 2026 3:32am
examples-nonmonorepo Ready Ready Preview, Comment, Open in v0 May 8, 2026 3:32am
examples-svelte-web Ready Ready Preview, Comment, Open in v0 May 8, 2026 3:32am
examples-tailwind-web Ready Ready Preview, Comment, Open in v0 May 8, 2026 3:32am
examples-vite-web Ready Ready Preview, Comment, Open in v0 May 8, 2026 3:32am
turbo-site Ready Ready Preview, Comment, Open in v0 May 8, 2026 3:32am

@anthonyshew anthonyshew merged commit 5e9cee5 into main May 8, 2026
46 checks passed
@anthonyshew anthonyshew deleted the shew/8327b branch May 8, 2026 03:41
anthonyshew pushed a commit that referenced this pull request May 8, 2026
## Release v2.9.11-canary.3

> [!CAUTION]
> Versioned docs aliasing FAILED. [View
logs](https://github.com/vercel/turborepo/actions/runs/25556157819)

### Changes

- fix: Include file URIs in LSP lifecycle logs (#12751) (`e64060f`)
- fix: Handle JSON decoration visitor depth (#12752) (`5e9cee5`)
- fix: Resolve relative `turbo path` in VS Code extension (#12753)
(`ca09ff1`)
- fix: Preserve Bun nested dependencies during prune (#12754)
(`84a161f`)
- fix: Prefer installed Turbo for LSP (#12755) (`e8e4df4`)
- release(turborepo): 2.9.11-canary.2 (#12750) (`4084382`)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
anthonyshew pushed a commit that referenced this pull request May 9, 2026
## Release v2.9.11

> [!CAUTION]
> Versioned docs aliasing FAILED. [View
logs](https://github.com/vercel/turborepo/actions/runs/25582894003)

### Changes

- release(turborepo): 2.9.10 (#12745) (`4b3e7cc`)
- ci: Publish VS Code extension on release (#12747) (`1293d22`)
- fix: Start daemon for VSCode Extension from the extension itself
(#12749) (`07a56d3`)
- release(turborepo): 2.9.11-canary.1 (#12748) (`0532c83`)
- fix: Include file URIs in LSP lifecycle logs (#12751) (`e64060f`)
- fix: Handle JSON decoration visitor depth (#12752) (`5e9cee5`)
- fix: Resolve relative `turbo path` in VS Code extension (#12753)
(`ca09ff1`)
- fix: Preserve Bun nested dependencies during prune (#12754)
(`84a161f`)
- fix: Prefer installed Turbo for LSP (#12755) (`e8e4df4`)
- release(turborepo): 2.9.11-canary.2 (#12750) (`4084382`)
- ci: Parallelize LSP release publishing (#12758) (`25aba68`)
- fix: Reduce VS Code extension startup popups (#12759) (`3c9ab14`)
- fix: Support `turbo.jsonc` in VS Code extension (#12760) (`3b3776b`)
- fix: Remove VS Code task key gradient (#12761) (`00c43d4`)
- release(turborepo): 2.9.11-canary.3 (#12756) (`bdeb64a`)
- chore: Release v2.9.11-canary.4 (#12762) (`20fa5c8`)
- ci: Stop VS Code publish from blocking release PR (#12763) (`8a0bd8b`)
- release(turborepo): 2.9.11-canary.5 (#12764) (`bfffbaa`)
- fix: Publish VS Code extension from release tag (#12765) (`2db74b4`)
- fix: Support shimmed VS Code LSP probes (#12767) (`e7c4575`)
- release(turborepo): 2.9.11-canary.6 (#12766) (`5a4310d`)
- release(turborepo): 2.9.11-canary.7 (#12768) (`87d468b`)
- fix: Allow TURBO_EXTENDS in LSP diagnostics (#12770) (`a968db7`)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant