Skip to content

fix: resolve paths used in the node-gyp-build fn #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarshallOfSound wants to merge 4 commits into from
Closed

fix: resolve paths used in the node-gyp-build fn #168

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a93e69
fix: resolve paths used in the node-gyp-build fn
MarshallOfSound Nov 9, 2022
0a87e02
spec: add unit test for resolved node-gy-build dependency
MarshallOfSound Nov 11, 2022
d80831c
refactor: use length > 0 checks instead of truthy checks
MarshallOfSound Nov 11, 2022
2e5e0b5
Merge branch 'main' into master
styfle Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions src/asset-relocator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -934,19 +934,21 @@ module.exports = async function (content, map) {
}
break;
case NODE_GYP_BUILD:
if (node.arguments.length === 1 && node.arguments[0].type === 'Identifier' &&
node.arguments[0].name === '__dirname' && knownBindings.__dirname.shadowDepth === 0) {
transformed = true;
let resolved;
try {
resolved = nodeGypBuild.path(dir);
}
catch (e) {}
if (resolved) {
staticChildValue = { value: resolved };
staticChildNode = node;
emitStaticChildAsset(path);
return backtrack(this, parent);
if (node.arguments.length) {
const arg = computePureStaticValue(node.arguments[0], false).result;
if (arg && arg.value) {
transformed = true;
let resolved;
try {
resolved = nodeGypBuild.path(arg.value);
}
catch (e) {}
if (resolved) {
staticChildValue = { value: resolved };
staticChildNode = node;
emitStaticChildAsset(path);
return backtrack(this, parent);
}
}
}
break;
Expand Down