fix: Use computed node-gyp-build path #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickael9
force-pushed
the
computed-node-gyp-build-path
branch
from
0d01d32 to
7d08ab2
Compare
mickael9
changed the title
mickael9
force-pushed
the
computed-node-gyp-build-path
branch
from
7d08ab2 to
1035b59
Compare
mickael9
changed the title
Member
|
Looks like like we need to upgrade node
|
|
🎉 This PR is included in version 1.7.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
styfle
added a commit
that referenced
this pull request
Jul 4, 2025
…#198) Extracted from #194 This is taking advantage of #185, which used a function in node-gyp-build to compute the path. Some moons ago, [node-gyp-build.js#L62-L75](https://github.com/prebuild/node-gyp-build/blob/v4.8.4/node-gyp-build.js#L62-L75) was updated with a function to resolve native addons from the prebuilds directory. All we have to do here is update `node-gyp-build`. This enables assets relocation for packages like [bcrypt v6.0.0](https://www.npmjs.com/package/bcrypt?activeTab=code) I added some tests according to the platform used in CI. Hopefully, the architecture and the fixtures align well. --------- Co-authored-by: Steven <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on existing PR #168 by @MarshallOfSound
I rebased the original commits except for the one introducing the tests which I have rewritten
Instead of requiring an external library (ffi-napi), I created a dummy binding that node-pre-gyp can use as input with a predictable binding file path that won't depend on the platform.