Skip to content

[rollout] feat: add enable_sleep_mode=false update to use expandable_segments when in RolloutMode.STANDALONE#4524

Closed
chenjiaoAngel wants to merge 4 commits intoverl-project:mainfrom
chenjiaoAngel:sleep_up
Closed

[rollout] feat: add enable_sleep_mode=false update to use expandable_segments when in RolloutMode.STANDALONE#4524
chenjiaoAngel wants to merge 4 commits intoverl-project:mainfrom
chenjiaoAngel:sleep_up

Conversation

@chenjiaoAngel
Copy link
Copy Markdown
Contributor

What does this PR do?

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

add enable_sleep_mode=false update to use expandable_segments when in RolloutMode.STANDALONE

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vLLM async server to disable sleep mode and enable expandable segments when running in STANDALONE mode. The logic correctly modifies the enable_sleep_mode argument for the vLLM engine. However, there is a critical issue where the set_expandable_segments function is called without being imported, which will cause a runtime error. This needs to be fixed by adding the appropriate import statement.

@chenjiaoAngel chenjiaoAngel changed the title [rollout][feat]: add enable_sleep_mode=false update to use expandable_segments when in RolloutMode.STANDALONE [rollout]feat: add enable_sleep_mode=false update to use expandable_segments when in RolloutMode.STANDALONE Dec 16, 2025
@chenjiaoAngel chenjiaoAngel changed the title [rollout]feat: add enable_sleep_mode=false update to use expandable_segments when in RolloutMode.STANDALONE [rollout] feat: add enable_sleep_mode=false update to use expandable_segments when in RolloutMode.STANDALONE Dec 16, 2025
@wuxibin89 wuxibin89 closed this Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants