[doc] chore: Bug fixes for the qwen3-235b model in 256k scenarios#5908
Merged
wucong25 merged 4 commits intoverl-project:mainfrom Apr 8, 2026
Merged
[doc] chore: Bug fixes for the qwen3-235b model in 256k scenarios#5908wucong25 merged 4 commits intoverl-project:mainfrom
wucong25 merged 4 commits intoverl-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Qwen3-235B training script to target the Instruct model and GSM8K dataset, alongside adjustments to Megatron parallelism, pipeline layer configurations, and optimizer hyperparameters. A critical configuration error was identified where the expert parallel size (train_ep=16) exceeds the calculated data parallel size (8) for the default 16-node setup, which will cause initialization failure.
wucong25
reviewed
Apr 8, 2026
| # Actor Model Configuration | ||
| ACTOR_ARGS=( | ||
| actor_rollout_ref.actor.strategy=megatron | ||
| # actor_rollout_ref.actor.strategy=megatron |
wucong25
previously approved these changes
Apr 8, 2026
wucong25
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fixes for the qwen3-235b model in 256k scenarios
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,megatron,veomni,sglang,vllm,rollout,trainer,ci,training_utils,recipe,hardware,deployment,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,cfg,reward,fully_async,one_step_off,like[megatron, fsdp, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][fsdp, megatron] feat: dynamic batchingTest
API and Usage Example
# Add code snippet or script demonstrating how to use thisDesign & Code Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace. (If not accessible, please try the Feishu group (飞书群).)recipesubmodule, please also update the reference to the submodule commit viagit submodule update --remoteorcd recipe && git pull origin main.