Skip to content

[rollout] feat: add inter-node TRT-LLM rollout support for trtllm#5992

Open
Superjomn wants to merge 3 commits intoverl-project:mainfrom
Superjomn:feat/init-docs-push
Open

[rollout] feat: add inter-node TRT-LLM rollout support for trtllm#5992
Superjomn wants to merge 3 commits intoverl-project:mainfrom
Superjomn:feat/init-docs-push

Conversation

@Superjomn
Copy link
Copy Markdown
Collaborator

…ation

What does this PR do?

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, veomni, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward, fully_async, one_step_off
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

@Superjomn Superjomn changed the title [rollout] feat: add inter-node TRT-LLM rollout support [rollout] feat: add inter-node TRT-LLM rollout support for trtllm Apr 13, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces unit and integration tests for multi-node and multi-replica TRT-LLM rollout scenarios, including a new test file for inter-node rollout. It also adds a bounds check in the get_pgs_and_bundle_indices method to prevent an IndexError when calculating placement group indices. I have no feedback to provide.

The OpenAI chat completion request requires the TRT-LLM server to have
a tokenizer, but the default ppo_trainer Hydra config sets
skip_tokenizer_init=True. Set it to False in the test fixture to match
the pattern in test_standalone_rollout.py.
@Superjomn Superjomn force-pushed the feat/init-docs-push branch from 886bcdc to 4da8d93 Compare April 15, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant