Skip to content

vertx-web-api-contract using problematic version of networknt/json-schema-validator #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jphorx opened this issue Feb 9, 2020 · 0 comments · Fixed by #1540
Closed

vertx-web-api-contract using problematic version of networknt/json-schema-validator #1528

jphorx opened this issue Feb 9, 2020 · 0 comments · Fixed by #1540
Assignees
Labels
component/api-contract/enhancement New features & improvements for vertx-web-api-contract
Milestone

Comments

@jphorx
Copy link

jphorx commented Feb 9, 2020

Version

3.8.5

Context

I encountered a stack overflow exception while creating a router based upon a model where there are schema components that include optional properties that can create circular references.

In researching this issue, I've determined it to be due to a known defect in networknt/json-schema-validator see here.
This issue has been resolved as of version 1.0.19 of networknt/json-schema-validator, but currently vertx-web-api-contract is using 1.0.4

I've upgraded to version 1.0.29 (the newest as of this writing) in my sandbox and it does indeed resolve this problem.

Do you have a reproducer?

No

Steps to reproduce

See Context

Extra

Seen on windows 10, OpenJDK 1.8 r212

@jphorx jphorx added the bug Something isn't working label Feb 9, 2020
@slinkydeveloper slinkydeveloper added component/api-contract/enhancement New features & improvements for vertx-web-api-contract and removed bug Something isn't working labels Feb 12, 2020
@slinkydeveloper slinkydeveloper self-assigned this Feb 12, 2020
@slinkydeveloper slinkydeveloper added this to the 3.8.6 milestone Feb 12, 2020
@vietj vietj modified the milestones: 3.8.6, 3.9.0 Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/api-contract/enhancement New features & improvements for vertx-web-api-contract
Development

Successfully merging a pull request may close this issue.

3 participants