-
Notifications
You must be signed in to change notification settings - Fork 331
Stack overflow when using recursive references, $ref #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Code uploaded, Push Request #181 |
@davidvisiedo The implementation makes perfect sense. I have asked other developers to review the code as they know more about this area. Thanks a lot for your help. |
stevehu
added a commit
that referenced
this issue
Aug 7, 2019
Fix issue #180: Prevents recursive parsing of $ref references.
@davidvisiedo I have merged the PR to the master branch. Wait for another PR to be reviewed/tested to have another release. Thanks a lot for your help. |
This was referenced Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think this issue is related to #59 and #36.
I get a stack overflow when refs are recursive (example copied from #59).
Related to https://json-schema.org/latest/json-schema-core.html#rfc.section.8.3.1
"A schema MUST NOT be run into an infinite loop against a schema. For example, if two schemas "#alice" and "#bob" both have an "allOf" property that refers to the other, a naive validator might get stuck in an infinite recursive loop trying to validate the instance. Schemas SHOULD NOT make use of infinite recursive nesting like this; the behavior is undefined. "
Example:
The text was updated successfully, but these errors were encountered: