Configurable server port for the tests

[brunoais]

Currently

On my PC, port 8080 is permanently in use for a personal server.
Currently, every time I want to test I have either to change the port on multiple places or turn off my server so that vert.x can bind to a port.

Request

May one change vert.x's testing framework so it may read (maybe in a properties file?) the port vert.x should listen to?
If so, how do you suggest?

[pmlopes]

Hummm that will be a hard one to solve, you need to review all tests... Or run tests inside docker...

[brunoais]

Why would that be?

[pmlopes]

because the port is not configurable (at the moment) so you would need to look into all super classes that the tests extend and make it configurable there. Anyway it should be some work but i guess it won't be a paramount.

[cescoffier]

Maybe I don't understand, but why are you not using the port 0 or the method explained in http://vertx.io/blog/vert-x-application-configuration/

[brunoais]

I don't know.

[brunoais]

@pmlopes We could use automatic ports given by ServerSocket. Looks correct to me...

[pmlopes]

we're not using port 0 because that feature got introduced with 3.2 if i'm not mistaken and vertx-web tests predate that. Maybe we should refactor the tests to do so and probably use vertx-unit instead of the blocking api we currently have. But that my friends is a huge refactor, not complicated but time consuming :)

[cescoffier]

Yes, you are right, it was introduced in vert.x 3.2

[vietj]

keep in mind that using a specific port can be quite useful when you want to use wireshark to see what's happening on the wire

[brunoais]

I've been dwelling on this from time to time and this is what I came up with:

• Add a System property that is read when the tests are started.
• Use the port number specified in the System property, otherwise, use automatic ports.
• If a port is in use (for example, tests that require multiple ports), then:
  • Use the port with the following number (increased by 1) as specified in the System property.
  • Otherwise, use a different automatic port for the new connection.

What do you think about that ideology?

[AnthonyMBonafide]

Would it suffice to update the base class, WebTestBase, with the described logic, and update its subclasses to use this newly added functionality from the super class rather then using hard-coding values like 8080?

[biolearning]

@pmlopes, I apply to pick up this issue and update that with the logic as describered by @brunoais.
If approved, how can I proceed this 'quick win'?

[pmlopes]

@biolearning sorry for the late reply, sure you can proceed