require process rather than using global #56
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello maintainers! First of all, thanks for working on vfile, I've been using this a lot (especially with remark) and it's been a lifesaver. tl;dr, webpack versions 1-4 used to automatically polyfill node.js libraries and the next version, version 5 doesn't. While migrating a larger project of mine, I ran into a scenario where vfile was breaking because it wasn't loading my `process` polyfill because `vfile` is using `process` as a global. Here is the related webpack issue: webpack/webpack#11282
|
@wooorm instead of this approach, should I instead add a |
|
Hi Jack! a) I believe it is possible to configure webpack to include it? b) this change breaks CI See also previous webpack issues in our org: https://github.com/search?q=org%3Avfile+webpack&type=Issues |
|
Thanks for getting back to me @wooorm I thought I tried making that change, but I can try it again. In the meantime, I'll close this PR. |
|
Alright, please let me know how that goes! |
|
Any update on this? Similar issues with webpack 5 for us. |
|
@Gervwyk this is a conversation about webpack 5. And it's a closed PR, there is not going to be an update. |
wooorm
added a commit
that referenced
this pull request
Dec 6, 2020
Many new developers do not know how to configure webpack. When they use a package that somewhere deep down uses `path` or `process` or whatnot, through webpack 5, they mistakingly think this package does not work in browsers. This infuriating mistake by webpack leads to superfluous work for maintainers and bigger bundles for users because polyfills add bloat. See: * <https://blog.sindresorhus.com/webpack-5-headache-b6ac24973bf1> * <vercel/next.js#16022> Note that this change shaves off 40% from the bundle size compared to including `path` and `process`, however, it will double the bundlephobia size (because it normally does not include path/process) and will hurt folks who depend on another project that includes `path`. Related to #16. Related to #28. Related to #38. Related to #35. Related to #56. Related to #57. Related to #58. Related to remarkjs/react-markdown#492. Related to remarkjs/react-markdown#514. Reviewed-by: Christian Murphy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello maintainers!
First of all, thanks for working on vfile, I've been using this a lot (especially with remark) and it's been a lifesaver.
tl;dr, webpack versions 1-4 used to automatically polyfill node.js libraries and the next version, version 5, doesn't.
While migrating a larger project of mine, I ran into a scenario where vfile was breaking because it wasn't loading my
processpolyfill becausevfileis usingprocessas a global.Here is the related webpack issue: webpack/webpack#11282