Skip to content

Add new data table #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Add new data table #141

merged 3 commits into from
Oct 30, 2023

Conversation

njooma
Copy link
Member

@njooma njooma commented Oct 27, 2023

Since MovementSensor is no longer a sensor type, we can't just reuse the SensorWidget like we used to. So I created a new data table to reuse across sensors and movement sensors and anything else that provides a map.

flyby: change the {Key? key} to {super.key}

@njooma njooma requested a review from a team as a code owner October 27, 2023 22:07
@benjirewis benjirewis removed their request for review October 30, 2023 16:48
@benjirewis
Copy link
Member

This seems reasonable, but I just don't have the context to approve it 😆 . Gonna remove myself as a reviewer.

@njooma njooma merged commit 5a70f1c into viamrobotics:main Oct 30, 2023
@njooma njooma deleted the implements-readings branch October 30, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants