RSDK-7220 - Ml training wrappers #206
Conversation
lib/src/app/ml_training.dart
Outdated
| /// gRPC client for the [MlTrainingClient]. Used for working with ML training jobs. | ||
| /// | ||
| /// All calls must be authenticated. | ||
| class MlTrainingClient { |
There was a problem hiding this comment.
Ml should be ML: https://dart.dev/effective-dart/style#do-capitalize-acronyms-and-abbreviations-longer-than-two-letters-like-words
2 Letters should still be fully capitalized
lib/src/app/ml_training.dart
Outdated
| @@ -0,0 +1,70 @@ | |||
| import 'package:viam_sdk/protos/app/ml_training.dart'; | |||
|
|
|||
| /// gRPC client for the [MlTrainingClient]. Used for working with ML training jobs. | |||
There was a problem hiding this comment.
This is the MLTrainingClient so this docstring is recursive lol. Should this be for the ML Training Service?
There was a problem hiding this comment.
Ooh interesting! I copied this from data.dart but I think this is a mistake cribbed from resources. Since there's no base abstract Data type or MLTraining type that the clients inherit from, I think both should be copying what app.dart does instead. Will update both here.
lib/src/app/ml_training.dart
Outdated
| /// Submits a custom training job request. | ||
| /// | ||
| /// Returns the new job's ID. | ||
| Future<String> submitCustomTrainingJob(String orgId, String datasetId, String modelName, String modelVersion, registryItemId) async { |
There was a problem hiding this comment.
[nit] registryItemId does not have an explicit type
stuqdog
force-pushed
the
ml-training-wrappers
branch
from
9c84c1b to
b89bacc
Compare
No description provided.