Skip to content

[RSDK-9633] delete discover components #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2025
Merged

[RSDK-9633] delete discover components #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f99662e
delete
JohnN193 Mar 5, 2025
33f73b7
remove discoveryQuery
JohnN193 Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions lib/src/robot/client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,20 +56,6 @@ class RobotClientOptions {
: dialOptions = DialOptions()..credentials = Credentials.locationSecret(locationSecret);
}

/// {@category Viam SDK}
/// Represents a discovery query in the SDK to query for discoverable components.
///
/// deprecated, remove on march 10th
class DiscoveryQuery {
final String subtype;
final String model;
final Map<String, dynamic> extra;

DiscoveryQuery({required this.subtype, required this.model, Map<String, dynamic>? extra}) : extra = extra ?? {};

Struct get extraStruct => extra.toStruct();
}

/// {@category Viam SDK}
/// Represents the result of a discovery query.
class Discovery {
Expand Down Expand Up @@ -336,26 +322,6 @@ class RobotClient {
return await _client.getCloudMetadata(rpb.GetCloudMetadataRequest());
}

/// Deprecated: use the Discovery Service APIs instead.
///
/// Discover components that the robot can connect to, given specific query metadata.
///
/// ```
/// var queries = [DiscoveryQuery(subtype: 'camera', model: 'webcam', extra: {'username': 'admin', 'password': 'admin'})];
/// var discoveredComponents = await machine.discoverComponents(queries);
/// ```
Future<List<Discovery>> discoverComponents([List<DiscoveryQuery> queries = const []]) async {
final request = rpb.DiscoverComponentsRequest()
..queries.addAll(queries.map((sdkQuery) => rpb.DiscoveryQuery()
..subtype = sdkQuery.subtype
..model = sdkQuery.model
..extra = sdkQuery.extraStruct));

_logger.w("RobotClient.discoverComponents is deprecated. It will be removed on March 10 2025. Use the DiscoveryService APIs instead.");
final response = await _client.discoverComponents(request);
return response.discovery.map((d) => Discovery.fromProto(d)).toList();
}

/// GetModelsFromModules returns the list of models supported in modules on the machine.
///
/// ```
Expand Down
31 changes: 0 additions & 31 deletions test/unit_test/mocks/service_clients_mocks.mocks.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,37 +355,6 @@ class MockRobotServiceClient extends _i1.Mock
)
as _i4.ResponseFuture<_i9.GetModelsFromModulesResponse>);

@override
_i4.ResponseFuture<_i9.DiscoverComponentsResponse> discoverComponents(
_i9.DiscoverComponentsRequest? request, {
_i3.CallOptions? options,
}) =>
(super.noSuchMethod(
Invocation.method(
#discoverComponents,
[request],
{#options: options},
),
returnValue: _FakeResponseFuture_2<_i9.DiscoverComponentsResponse>(
this,
Invocation.method(
#discoverComponents,
[request],
{#options: options},
),
),
returnValueForMissingStub:
_FakeResponseFuture_2<_i9.DiscoverComponentsResponse>(
this,
Invocation.method(
#discoverComponents,
[request],
{#options: options},
),
),
)
as _i4.ResponseFuture<_i9.DiscoverComponentsResponse>);

@override
_i4.ResponseFuture<_i9.FrameSystemConfigResponse> frameSystemConfig(
_i9.FrameSystemConfigRequest? request, {
Expand Down