add last known update to updateRobotPart and updateFragment #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
reviewed
Apr 28, 2025
lib/src/app/app.dart
Outdated
| final updateRobotPartRequest = UpdateRobotPartRequest() | ||
| ..id = partId | ||
| ..name = name | ||
| ..robotConfig = robotConfig.toStruct(); | ||
| if (lastKnownUpdate != null) updateRobotPartRequest.lastKnownUpdate = lastKnownUpdate; |
There was a problem hiding this comment.
I think this is causing tests to fail because the request is expecting a Timestamp but getting a DateTime.
Same in updateFragment below.
There was a problem hiding this comment.
thanks! yeah i saw the error but got busy with some other stuff, just looping back on the fix now
stuqdog
approved these changes
Apr 28, 2025
yeah i forgot an import, they are passing now. i don't know how to use dart lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.