Hardcode ip for provisioning, fix client used with apikey #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin49999
commented
May 14, 2025
| @@ -7,8 +7,6 @@ enum NetworkType { wifi, wired } | |||
|
|
|||
| /// {@category Viam SDK} | |||
| /// gRPC client for connecting to Viam's Provisioning Service | |||
| /// | |||
| /// All calls must be authenticated. | |||
There was a problem hiding this comment.
I think this is the one client where this doesn't apply
kevin49999
changed the title
kevin49999
commented
May 15, 2025
ale7714
approved these changes
May 15, 2025
clintpurser
approved these changes
May 15, 2025
Otterverse
reviewed
May 15, 2025
njooma
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to use the ip
10.42.0.1instead of a hostnameviam.setupduring provisioning. Usingviam.setupwhile using cellular (but connected to the hotspot) on iOS does not work and the requests fail.Also,
Testing in my example project, I couldn't get the init w/ api key to function (for provisioning): viamrobotics/viam_flutter_bluetooth_provisioning_widget#2
I think the host
provisioning.viamin this init for theProvisioningClientis outdated / doesn't match how it's setup when using an access token (usesviam.setup). Plus we want to use an ip now here as well