Expose flagImage className #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds to !128. Now consumers don't have to select the image within the flag using potentially unsafe selectors (that might break over time) but can use a constant. Sharpens namings on exposed classes: `classes.flag` becomes `flagContainer`, to express that the span around the img is targeted
Contributor
Author
|
sorry by providing the solution in 2 chunks. |
viclafouch
reviewed
Feb 15, 2024
Owner
No worries, thanks for your work ;) |
viclafouch
reviewed
Feb 15, 2024
viclafouch
reviewed
Feb 15, 2024
viclafouch
reviewed
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds to #128. Now consumers don't have to select the image within the flag using potentially unsafe selectors (that might break over time) but can use a constant. Sharpens namings on exposed classes:
classes.flagbecomesflagContainer, to express that thespanaround theimgis targeted