This repository was archived by the owner on Sep 15, 2023. It is now read-only.
Replace webpack's uglify with new uglify plugin to allow ES6 uglification#547
Open
amoshydra wants to merge 1 commit intovigetlabs:masterfrom
Open
Replace webpack's uglify with new uglify plugin to allow ES6 uglification#547amoshydra wants to merge 1 commit intovigetlabs:masterfrom
amoshydra wants to merge 1 commit intovigetlabs:masterfrom
Conversation
Author
|
Alternatively, should it provide user a way to use their own uglify plugin? webpackConfig.plugins.push(
new webpack.DefinePlugin(TASK_CONFIG.javascripts.production.definePlugin),
(webpackConfig.uglifyPlugin) // Allow the use of other uglifier
? new webpackConfig.uglifyPlugin(uglifyConfig)
: new webpack.optimize.UglifyJsPlugin(uglifyConfig),
new webpack.NoEmitOnErrorsPlugin()
) |
Author
|
Note: This is a potential breaking change since PreviouslyuglifyConfig = {
compress: false,
mangle: false,
beautify: true,
comments: true,
sourceMap: true,
}NowuglifyConfig = {
uglifyOptions: {
compress: false,
mangle: false,
output: {
beautify: true,
comments: true,
},
},
sourceMap: true,
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will automatically allow webpack to minify ES6 code.
Related to #505