Skip to content

[Backport] Responsive Design Footers bottom of screen on mobile devices #15118 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1,513 commits into from
Jun 4, 2018

Conversation

vijay-wagento
Copy link
Owner

Original Pull Request

magento#15353
Solved footer issue for mobile view

Description

Solved footer issue for mobile view

Fixed Issues (if relevant)

  1. Responsive Design, Footers do not snap to bottom of screen on mobile devices magento/magento2#15118: Responsive Design, Footers do not snap to bottom of screen on mobile devices
  2. ...

Manual testing scenarios

  1. Check footer in mobile

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

slavvka and others added 30 commits April 27, 2018 11:31
…lues magento#14894

 - Merge Pull Request magento#14894 from rogyar/magento2:2.1-aggregations-fix
 - Merged commits:
   1. 9b1beab
   2. 912c06c
Accepted Public Pull Requests:
 - magento#14894: [Backport] Fix aggregations use statements and return values (by @rogyar)
…e symbol magento#14902

 - Merge Pull Request magento#14902 from rogyar/magento2:2.1-admin-custom-currency-fix
 - Merged commits:
   1. 5c58595
magento#14901

 - Merge Pull Request magento#14901 from rogyar/magento2:2.1-categorysave-unnecessary-var
 - Merged commits:
   1. b3a7d7f
…art enabled magento#14899

 - Merge Pull Request magento#14899 from rogyar/magento2:2.1-addtocart-redirect-fix
 - Merged commits:
   1. 3cfe20d
…amic magento#14911

 - Merge Pull Request magento#14911 from rogyar/magento2:2.1-improve-cart-qty-validation
 - Merged commits:
   1. 838f08f
Accepted Public Pull Requests:
 - magento#14901: [Backport] Refactoring: remove unuseful temporary variable (by @rogyar)
…14903

 - Merge Pull Request magento#14903 from rogyar/magento2:2.1-order-grid-export-fix
 - Merged commits:
   1. 4bb9d27
   2. 67268ca
   3. 9c5517a
Accepted Public Pull Requests:
 - magento#14911: [Backport] Switch updatecart qty input validators to dynamic (by @rogyar)
 - magento#14899: [Backport] Disable add to cart button when redirect to cart enabled (by @rogyar)
Accepted Public Pull Requests:
 - magento#14902: [Backport] Prices aren't readable when using custom price symbol (by @rogyar)


Fixed GitHub Issues:
 - magento#12430: While assigning prices to configurable products, prices aren's readable when using custom price symbol. (reported by @quisse) has been fixed in magento#14902 by @rogyar in 2.1-develop branch
   Related commits:
     1. 5c58595
 - Merge Pull Request magento#14922 from rogyar/magento2:2.1-observer-name-typo
 - Merged commits:
   1. db28e02
AnshuMishra17 and others added 28 commits May 23, 2018 20:08
 - Merge Pull Request magento#15465 from mzeis/magento2:2.1-develop-PR-port-15431
 - Merged commits:
   1. fe61969
Accepted Public Pull Requests:
 - magento#15436: [Backport] Removed redundant else statement (by @rogyar)
 - magento#15444: [Backport] Added language translation for message string (by @yogeshks)
Accepted Public Pull Requests:
 - magento#15465: [Backport] typo correction (by @mzeis)
…d use the store set on the collection magento#13756

 - Merge Pull Request magento#13756 from alepane21/magento2:bugfix/issue-13704-backport-2.1
 - Merged commits:
   1. 2239f3d
   2. 6f556ff
   3. 915be6e
… pricing magento#15445

 - Merge Pull Request magento#15445 from JeroenVanLeusden/magento2:2.1-develop-PR-port-15089
 - Merged commits:
   1. 3d05e6b
…agento#15548

 - Merge Pull Request magento#15548 from VitaliyBoyko/magento2:Fix-typos-in-Multishipping-and-User-module2-1
 - Merged commits:
   1. 485fd48
…nto#15522

 - Merge Pull Request magento#15522 from rogyar/magento2:2.1-unset-quote-recollect
 - Merged commits:
   1. bddb976


 - Merge Pull Request magento#15563 from rogyar/magento2:2.1-adjust-return-statements
 - Merged commits:
   1. 7c65f0a
[EngCom] Public Pull Requests - 2.1-develop
 - Merge Pull Request magento#15619 from dmytro-ch/magento2:fix/2.1-phpdocs-incorrect-type-hinting
 - Merged commits:
   1. ab64a2c
Accepted Public Pull Requests:
 - magento#15619: Fix incorrect type hinting in PHPDocs (by @dmytro-ch)
 - magento#15563: [Backport] Correct functions return statement (by @rogyar)
 - magento#15522: [Backlog] Add resetting of triggerRecollection flag (by @rogyar)
 - magento#15445: [Backport] Fix unnecessary recalculation of product list pricing (by @JeroenVanLeusden)


Fixed GitHub Issues:
 - magento#13992: Incorrect phpdoc should be Shipment\Item not Invoice\Item (reported by @ThisIsRuddy) has been fixed in magento#15619 by @dmytro-ch in 2.1-develop branch
   Related commits:
     1. ab64a2c

 - magento#9580: Quote Attribute trigger_recollect causes a timeout (reported by @bh-ref) has been fixed in magento#15522 by @rogyar in 2.1-develop branch
   Related commits:
     1. bddb976

 - magento#14941: Unnecessary recalculation of product list pricing causes huge slowdowns (reported by @paales) has been fixed in magento#15445 by @JeroenVanLeusden in 2.1-develop branch
   Related commits:
     1. 3d05e6b
vijay-wagento pushed a commit that referenced this pull request Jun 4, 2018
# This is the 1st commit message:
magento#10765 add confirmation and lock_expires labels to customer grid CSV export

# This is the commit message #2:

magento#10765 Add tests for added methods

# This is the commit message #3:

10765 code refactoring
@vijay-wagento vijay-wagento merged commit 62ed882 into 2.1-develop Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.