-
Notifications
You must be signed in to change notification settings - Fork 101
Hack to use inputsecret instead of inputdialog for password #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I consider Vim an single user system and really expect people to setup profiles for connection management. The profile password is in plain text in their configuration files. As to your change, if you are using a Vim with a GUI, the inputdialog() opens a new window for input, when using inputsecret(), the prompt is at the command prompt, which is different from all other prompts. For that reason I would prefer not to use this change. It would be better if the inputdialog() could mask the input. Or just like inputdialog() when using a GUI, still launch the dialog, but mask the input. That would most likely be a more simple feature request. David |
I haven't been using GUI so I wasn't aware that inputsecret() worked different from other prompts. Making them behave consisent is probably a feature request for gvim then. I'm using profiles, but I can't put clear text passwords in them. |
Just a thought, never tried. What about storing your profiles in a vim encrypted file. Then you would only open the encrypted file once and can store the passwords clear text there. |
Thanks, I'll try that. |
Posted by David Fishburn New Features ------------ - Overhauled the prompting for SQL statement variable substitution (i.e. host variables, named parameters, question marks, ...). The actions and user interface are hopefully more clear, useful and efficient. For a full updated tutorial on how it works see :h dbext-tutorial-variables - Saved variables can now hold multiple values for the same parameter, see :h dbext-tutorial-variables for how it works. - Added C++ language support for variables (pull #12) (Anatolii Sakhnik). - Added the ability to specify special characters (i.e. "\t") for column delimiters when using ODBC or DBI database types (Michael Krnac). - Added new option, "passwd_use_secret", which is used when entering a password, if the value should be masked. When using a GUI version of Vim, the prompt is not displayed in a dialog unlike the other parameters. This option is OFF (0) by default. (pull #13) (petteja) - Added new option, "strip_into", which is used when executing statements which have variable assignments using the INTO clause. To test these queries, you need to remove the INTO clause so that when they execute the query you can see the result set returned. This was on for all databases, but for TransactSQL or TSQL databases like SQLSRV and ASE, stripping the INTO clause may be the wrong action. Now it can be controlled using this setting. This can also be set / overridden using DBSetOption strip_into=1 or as part of a dbext profile. - Added new option, "strip_at_variables", which is executing statements which have variable assignments in the SELECT list instead of the INTO clause. To test these queries, you need to remove the assignments when they execute to see the result set returned. This was on for all databases, but for TransactSQL or TSQL databases like SQLSRV and ASE, stripping the variable assignments in the SELECT list is required. This can be controlled via this setting. This can also be set / overridden using DBSetOption strip_at_variables=1 or as part of a dbext profile. Bug Fixes --------- - Minor correction to DBSetVar example (Cedric Simon). - When deleting a buffer, all syntax highlighting of your existing buffer is sometimes lost, which was a problem with one of the dbext autocmds (Anatolii Sakhnik). - Update Postgres get column list join conditions (pull #9) (Dickson S. Guedes). - dbext autocmd for checking for modelines messed up the jumplist (Justin M. Keyes)
Did that work, do you have a simple example I could add to dbext.txt? |
Password shouldn't be displayed in cleartext when prompted for.