feat: Skip FORCE INDEX for JOIN #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@muglug |
|
@sergiosalvatore @aaronm67 @MelechMizrachi |
aaronm67
approved these changes
Mar 10, 2025
|
Thank you! Ran some tests on this and everything seems to work well, thanks for the contribution (and sorry for the delay). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore FORCE INDEX specified after JOIN.
Adjust pointers in
buildJoin()because there was a discrepancy between JOIN and other pointers assumed when calling SQLParser::skipIndexHints.If you have a better policy, please let us know.