Skip to content

fix(setup): dep and scoped imports #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Conversation

NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Feb 20, 2020

@vinckobb This works. A couple things I noticed from your comments on the repo.

  • Looks like you are on Windows, is that correct? Could be something particular there.
  • This changes to core modules 6.3 and a specific runtime however should work just fine with 6.4, I just have those specific runtimes installed so feel free to change runtime to 6.4 and core modules back to what you had after merging.
  • The most important could possibly be that I updated the imports to use @nativescript/angular which may help the Ivy compilation since that's the direct package (instead of the compat reference).
  • Also the "ngcc" reference in scripts may also be important.

For instance, when clearing you project completely and building fresh with:

tns run ios --emulator --env.aot --no-hmr

You should absolutely see the ngcc output during the build like this:

Warning: Entry point '@nativescript/angular' contains deep imports into '/Users/nathan/Documents/github/NathanWalker/tmp/nativescript-angular-demo/node_modules/tns-core-modules/ui/core/view/view', '/Users/nathan/Documents/github/NathanWalker/tmp/nativescript-angular-demo/node_modules/tns-core-modules/ui/layouts/layout-base', '/Users/nathan/Documents/github/NathanWalker/tmp/nativescript-angular-demo/node_modules/tns-core-modules/utils/types', '/Users/nathan/Documents/github/NathanWalker/tmp/nativescript-angular-demo/node_modules/tns-core-modules/file-system/file-system'. This is probably not a problem, but may cause the compilation of entry points to be out of order.
Compiling @angular/animations : fesm5 as esm5
Compiling @angular/animations : main as umd
Compiling @angular/animations : esm5 as esm5
Compiling @angular/animations : esm2015 as esm2015
Compiling @angular/animations : fesm2015 as esm2015
Compiling @angular/compiler/testing : fesm5 as esm5
Compiling @angular/compiler/testing : fesm2015 as esm2015
Compiling @angular/compiler/testing : esm2015 as esm2015
Compiling @angular/core : fesm5 as esm5
Compiling @angular/compiler/testing : esm5 as esm5
Compiling @angular/compiler/testing : main as umd
Compiling @angular/core : main as umd
Compiling @angular/core : fesm2015 as esm2015
Compiling @angular/core : esm5 as esm5
Compiling @angular/core : esm2015 as esm2015
Compiling @angular/common : fesm5 as esm5
Compiling @angular/animations/browser : fesm5 as esm5
Compiling @angular/animations/browser : main as umd
Compiling @angular/animations/browser : esm5 as esm5
Compiling @angular/animations/browser : esm2015 as esm2015
Compiling @angular/common : fesm2015 as esm2015
Compiling @angular/animations/browser : fesm2015 as esm2015
Compiling @angular/common : esm5 as esm5
Compiling @angular/core/testing : fesm2015 as esm2015
Compiling @angular/common : main as umd
Compiling @angular/common : esm2015 as esm2015
Compiling @angular/core/testing : fesm5 as esm5
Compiling @angular/core/testing : esm2015 as esm2015
Compiling @angular/animations/browser/testing : fesm5 as esm5
Compiling @angular/animations/browser/testing : fesm2015 as esm2015
Compiling @angular/platform-browser : fesm2015 as esm2015
Compiling @angular/animations/browser/testing : esm2015 as esm2015
Compiling @angular/animations/browser/testing : esm5 as esm5
Compiling @angular/common/http : fesm2015 as esm2015
Compiling @angular/common/testing : fesm2015 as esm2015
Compiling @angular/animations/browser/testing : main as umd
Compiling @angular/router : fesm2015 as esm2015
Compiling @angular/forms : fesm2015 as esm2015
Compiling @angular/common/http : fesm5 as esm5
Compiling @angular/common/http : esm5 as esm5
Compiling @angular/common/http : esm2015 as esm2015
Compiling @angular/common/http : main as umd
Compiling @angular/platform-browser/testing : fesm2015 as esm2015
Compiling @angular/common/http/testing : fesm5 as esm5
Compiling @angular/common/http/testing : esm2015 as esm2015
Compiling @angular/platform-browser-dynamic : fesm2015 as esm2015
Compiling @angular/common/http/testing : esm5 as esm5
Compiling @angular/common/http/testing : main as umd
Compiling @angular/common/http/testing : fesm2015 as esm2015
Compiling @angular/platform-browser : esm5 as esm5
Compiling @angular/platform-browser : fesm5 as esm5
Compiling @angular/platform-browser : main as umd
Compiling @angular/platform-browser : esm2015 as esm2015
Compiling @angular/platform-browser/animations : fesm5 as esm5
Compiling @angular/platform-browser/animations : esm2015 as esm2015
Compiling @angular/platform-browser/animations : esm5 as esm5
Compiling @angular/platform-browser/animations : fesm2015 as esm2015
Compiling @angular/platform-browser/animations : main as umd
Compiling @angular/core/testing : esm5 as esm5
Compiling @angular/platform-browser-dynamic : fesm5 as esm5
Compiling @angular/core/testing : main as umd
Compiling @angular/platform-browser-dynamic : esm2015 as esm2015
Compiling @angular/platform-browser-dynamic : esm5 as esm5
Compiling @angular/platform-browser-dynamic : main as umd
Compiling @angular/platform-browser/testing : fesm5 as esm5
Compiling @angular/platform-browser/testing : esm2015 as esm2015
Compiling @angular/platform-browser/testing : esm5 as esm5
Compiling @angular/platform-browser/testing : main as umd
Compiling @angular/platform-browser-dynamic/testing : fesm5 as esm5
Compiling @angular/platform-browser-dynamic/testing : esm2015 as esm2015
Compiling @angular/platform-browser-dynamic/testing : esm5 as esm5
Compiling @angular/common/testing : fesm5 as esm5
Compiling @angular/platform-browser-dynamic/testing : main as umd
Compiling @angular/common/testing : esm2015 as esm2015
Compiling @angular/common/testing : esm5 as esm5
Compiling @angular/platform-browser-dynamic/testing : fesm2015 as esm2015
Compiling @angular/common/testing : main as umd
Compiling @angular/router/testing : fesm5 as esm5
Compiling @angular/router : fesm5 as esm5
Compiling @angular/router : esm5 as esm5
Compiling @angular/router : esm2015 as esm2015
Compiling @angular/router/testing : esm2015 as esm2015
Compiling @angular/router : main as umd
Compiling @angular/router/testing : esm5 as esm5
Compiling @angular/router/testing : fesm2015 as esm2015
Compiling @angular/router/testing : main as umd
Compiling @angular/forms : fesm5 as esm5
Compiling @angular/forms : main as umd
Compiling @angular/forms : esm2015 as esm2015
Compiling @angular/forms : esm5 as esm5
Compiling @nativescript/angular : main as commonjs

Note that last line where it mentions @nativescript/angular. If you don't see that then ngcc for ivy prep is not running right on your end.

Hope this helps.

@vinckobb vinckobb merged commit eb8c550 into vinckobb:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants