Skip to content

feat: cks: allow setting ingressClassName#193

Open
joshsizer wants to merge 1 commit intovirtru-corp:mainfrom
joshsizer:cks-ingress-class-name
Open

feat: cks: allow setting ingressClassName#193
joshsizer wants to merge 1 commit intovirtru-corp:mainfrom
joshsizer:cks-ingress-class-name

Conversation

@joshsizer
Copy link

Proposed Changes

The annotation kubernetes.io/ingress.class is deprecated in favor of ingressClassName on Ingress resources: https://kubernetes.io/docs/concepts/services-networking/ingress/#deprecated-annotation

I haven't done any of the checklist items yet. If ya'll are open to this change let me know what else I should do to contribute this change.

Checklist

  • I have bumped the necessary versions
  • I have (re-)packaged the updated charts helm package $CHART_NAME -u
  • I have updated the repo index helm repo index .
  • I have added or updated documentation / readme (if appropriate)
  • I have verified that my changes have not introduced new lint errors

Testing Instructions

Compare the output of the two helm template commands:

cd cks
helm template .
helm template . --set ingress.ingressClassName=nginx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant