feat: cks: allow setting ingressClassName#193
Open
joshsizer wants to merge 1 commit intovirtru-corp:mainfrom
Open
feat: cks: allow setting ingressClassName#193joshsizer wants to merge 1 commit intovirtru-corp:mainfrom
joshsizer wants to merge 1 commit intovirtru-corp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The annotation
kubernetes.io/ingress.classis deprecated in favor of ingressClassName on Ingress resources: https://kubernetes.io/docs/concepts/services-networking/ingress/#deprecated-annotationI haven't done any of the checklist items yet. If ya'll are open to this change let me know what else I should do to contribute this change.
Checklist
helm package $CHART_NAME -uhelm repo index .Testing Instructions
Compare the output of the two helm template commands: