Update run workflow on main, plus Dependabot#6
Conversation
|
Warning Rate limit exceeded@johlju has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 21 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughA Dependabot configuration file was added to automate updates for GitHub Actions dependencies. The Docker image publishing workflow was updated to distinguish between tag and branch builds, with separate steps and tagging strategies for each, and explicit triggers for pushes to the main branch and tags. Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub
participant Workflow
participant DockerHub
participant GHCR
GitHub->>Workflow: Push to main or tag
alt Tag push
Workflow->>DockerHub: Build & push image (tag: ${{ tag }}, latest)
Workflow->>GHCR: Build & push image (tag: ${{ tag }}, latest)
else Main branch push
Workflow->>DockerHub: Build & push image (tag: main)
Workflow->>GHCR: Build & push image (tag: main)
end
Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
.github/workflows/docker-publish.yml (1)
62-77: Add cache-from / cache-to once registry creds are availableThe commented cache directives dramatically speed up multi-arch builds.
Consider enabling them now that the workflow logs in to both registries.- # cache-from: "type=registry,ref=ghcr.io/viscalyx/devshell-dsc:buildcache" - # cache-to: "type=registry,ref=ghcr.io/viscalyx/devshell-dsc:buildcache,mode=max" + cache-from: "type=registry,ref=ghcr.io/viscalyx/devshell-dsc:buildcache" + cache-to: "type=registry,ref=ghcr.io/viscalyx/devshell-dsc:buildcache,mode=max"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
.github/dependabot.yml(1 hunks).github/workflows/docker-publish.yml(3 hunks)
🔇 Additional comments (3)
.github/workflows/docker-publish.yml (3)
5-9:push.tagsglob misses pre-release tags
v*.*.*will not match pre-release tags likev1.2.3-rc1.
If you ship release candidates, broaden the glob, e.g.:- - 'v*.*.*' + - 'v*'
44-61: Duplicatelatesttag on every re-tag may overwrite stable imageEvery new tag push (e.g.,
v1.2.3,v1.2.4) rewriteslatest.
If you wantlatestto track only the default branch, move thelatesttag to the branch build instead of the tag build, or drop it here.No change suggested—verify intent.
11-14: Grantpackages: readto tighten least-privilege
docker/login-actionpushes via the Docker Hub / GHCR APIs, not via the GitHub Packages GraphQL API.
packages: writeis only needed forghcr.iopushes. If you ever stop pushing to GHCR, drop it; otherwise fine.
1 participant
This change is