fix(notifications): resolve analytics DB path from config, not $HOME default

cmd/hookwise/cmd_notifications.go

@@ -3,10 +3,12 @@ package main
 import (
 	"context"
 	"fmt"
+	"os"
 	"strings"
 
 	"github.com/spf13/cobra"
 	"github.com/vishnujayvel/hookwise/internal/analytics"
+	"github.com/vishnujayvel/hookwise/internal/core"
 	"github.com/vishnujayvel/hookwise/internal/notifications"
 )
 
@@ -27,14 +29,22 @@ surfaced via the status line or this command.`,
 		},
 	}
 
-	cmd.Flags().StringVar(&dataDir, "data-dir", "", "Path to the analytics SQLite DB file (defaults to ~/.hookwise/analytics.db)")
+	cmd.Flags().StringVar(&dataDir, "data-dir", "", "Path to the analytics SQLite DB file (defaults to config analytics.db_path / ~/.hookwise/analytics.db)")
 	cmd.Flags().IntVar(&limit, "limit", 20, "Maximum number of notifications to show")
 
 	return cmd
 }
 
 func runNotifications(cmd *cobra.Command, dataDir string, limit int) error {
-	db, err := analytics.Open(dataDir)
+	// Load config the same way the writer (dispatch) does so reader and writer
+	// agree on the DB path (ARCH-1: never hard-fail on a missing/broken config).
+	cwd, _ := os.Getwd()
+	config, err := core.LoadConfig(cwd)
+	if err != nil {
+		config = core.GetDefaultConfig()
+	}
+
+	db, err := analytics.Open(resolveAnalyticsDBPath(dataDir, config))
 	if err != nil {
 		return fmt.Errorf("failed to open analytics DB: %w", err)
 	}

cmd/hookwise/cmd_notifications_test.go

@@ -0,0 +1,50 @@
+package main
+
+import (
+	"bytes"
+	"context"
+	"os"
+	"path/filepath"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+	"github.com/vishnujayvel/hookwise/internal/notifications"
+)
+
+// TestNotifications_ReadsConfigDBPath is the #109 regression test: when a project
+// config sets a custom analytics.db_path, `notifications` (with no --data-dir flag)
+// must read THAT database — the same one `dispatch` writes to — not the default
+// ~/.hookwise/analytics.db. Before the fix, notifications ignored config and printed
+// "No notifications." from the default empty DB.
+func TestNotifications_ReadsConfigDBPath(t *testing.T) {
+	tmpDir := t.TempDir()
+	// Isolate the default state dir so the "default" DB is empty (and absent).
+	t.Setenv("HOOKWISE_STATE_DIR", filepath.Join(tmpDir, ".hookwise"))
+
+	customDB := filepath.Join(tmpDir, "custom-notifications.db")
+
+	// A project dir with a hookwise.yaml pointing analytics at the custom DB.
+	projectDir := filepath.Join(tmpDir, "project")
+	require.NoError(t, os.MkdirAll(projectDir, 0o755))
+	cfgYAML := "analytics:\n  enabled: true\n  db_path: " + customDB + "\n"
+	require.NoError(t, os.WriteFile(filepath.Join(projectDir, "hookwise.yaml"), []byte(cfgYAML), 0o644))
+
+	// Seed one notification into the CUSTOM DB via the real NotificationService.
+	db := openTestDB(t, customDB)
+	ns := notifications.NewNotificationService(db)
+	require.NoError(t, ns.Create(context.Background(), "budget", "budget_threshold", "Cost exceeded $99.00"))
+	db.Close()
+
+	// Run `notifications` from the project dir with NO --data-dir flag.
+	t.Chdir(projectDir)
+	cmd := newNotificationsCmd()
+	buf := &bytes.Buffer{}
+	cmd.SetOut(buf)
+	cmd.SetArgs([]string{})
+	require.NoError(t, cmd.Execute())
+
+	out := buf.String()
+	assert.Contains(t, out, "Cost exceeded $99.00",
+		"notifications must read the config's db_path and show seeded notification, not 'No notifications.' from the default DB")
+}