fix: handle aliases with dashes in DjangoGetter attribute resolution#1727
Open
Thiago88pe wants to merge 1 commit into
Open
fix: handle aliases with dashes in DjangoGetter attribute resolution#1727Thiago88pe wants to merge 1 commit into
Thiago88pe wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix TemplateSyntaxError when a Schema field uses an alias containing a dash (e.g. alias="CloudFront-Policy").
DjangoGetter.getattr was falling through to Django's template Variable(key).resolve() even for keys that are invalid template variable names. Django's parser rejects dashes, raising TemplateSyntaxError instead of a catchable error.
The fix adds a guard using re.compile(r"^[\w.]+$") to skip Variable.resolve for keys that contain characters outside the set Django Template Variables accept (word chars and dots). Dotted paths like "boss.name" continue to work normally.
Fixes: aliases with - in name (e.g. AWS CloudFront cookies headers). Fixes #1660