fix(hostname): allow undescore in hostName #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I didn't see this until just now, by chance. GitHub's notifications system sucks. Anyhow, you should have opened an issue first, I would have spotted it earlier. Question for you - do you really have hosts with underscore in their names, or is it a hypothetical? I'm just trying to pick up if there's any sense of urgency here 😉 |
Contributor
Author
|
there is no urgence anymore (for me), but yes is allowed in RFC (but not recommended) for example u can fond in S3 Bucket or GCP |
Owner
|
Released in v4.3.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow underscore in hostName