Skip to content

feat(vue-jsx): add filter #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 20, 2025
Merged

feat(vue-jsx): add filter #581

merged 4 commits into from
May 20, 2025

Conversation

sapphi-red
Copy link
Member

Description

Adds filter to plugin-vue-jsx so that it makes the plugin performant when used in rolldown-vite.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-significant 🔨 High priority enhancement (priority) label Apr 28, 2025
sapphi-red
sapphi-red commented Apr 28, 2025
View reviewed changes
packages/plugin-vue-jsx/src/index.ts
resolveId: {
filter: { id: exactRegex(ssrRegisterHelperId) },
handler(id) {
if (id === ssrRegisterHelperId) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to keep the if statements to keep the compat for Vite older than v6.3.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 28, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@vitejs/plugin-vue@581

npm i https://pkg.pr.new/@vitejs/plugin-vue-jsx@581

commit: 4d0e33b

@TheAlexLichter TheAlexLichter mentioned this pull request May 1, 2025
Open
@sapphi-red sapphi-red marked this pull request as draft May 14, 2025 10:46
@sapphi-red sapphi-red marked this pull request as ready for review May 19, 2025 09:40
@sapphi-red sapphi-red merged commit f66a009 into main May 20, 2025
16 checks passed
@sapphi-red sapphi-red deleted the feat/vue-jsx-add-filter branch May 20, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
p3-significant 🔨 High priority enhancement (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sapphi-red