Skip to content

chore: update type#11549

Closed
li-jia-nan wants to merge 2 commits into
vitejs:mainfrom
li-jia-nan:main
Closed

chore: update type#11549
li-jia-nan wants to merge 2 commits into
vitejs:mainfrom
li-jia-nan:main

Conversation

@li-jia-nan
Copy link
Copy Markdown
Contributor

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@li-jia-nan li-jia-nan changed the title type: update type chore: update type Jan 1, 2023
Copy link
Copy Markdown
Member

@ArnaudBarre ArnaudBarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assertion is not necessary can become wrong if people change the app tag.

I prefer to use ! as this only need here is to remove the null type.

CI is block for another reason. Fix: #11548

@li-jia-nan
Copy link
Copy Markdown
Contributor Author

This assertion is not necessary can become wrong if people change the app tag.

I prefer to use ! as this only need here is to remove the null type.

CI is block for another reason. Fix: #11548

I have changed it to !

@sapphi-red
Copy link
Copy Markdown
Member

sapphi-red commented Jan 1, 2023

About changing as to non-null assertion, there's already a PR here (and some related discussions): #10772

@li-jia-nan
Copy link
Copy Markdown
Contributor Author

About changing as to non-null assertion, there's already a PR here (and some related discussions): #10772

OK,I close this PR

@li-jia-nan li-jia-nan closed this Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants