perf: use URL.canParse#14068
Merged
Merged
Conversation
|
|
patak-cat
approved these changes
Aug 10, 2023
Member
patak-cat
left a comment
There was a problem hiding this comment.
I think we should wait to see what other features we get by bumping to 18.17.0. If it is only for this one, I think we could move forward without that using your helper. We are going to have another major before 18 goes EOL too if we want to bump it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use
URL.canParse(nodejs/node#47179, whatwg/url#763) if available that can skip the try-catch overhead.I don't think this improves the perf much but we can simplify this by removing the fallback polyfill when it's ready.
Maybe we can bump the target to Node 18.17.0 instead of 18 in Vite 5? (#14030)
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).