Skip to content

chore(deps): update miniflare to v3#14107

Merged
bluwy merged 1 commit into
vitejs:mainfrom
sapphi-red:chore/update-miniflare
Aug 21, 2023
Merged

chore(deps): update miniflare to v3#14107
bluwy merged 1 commit into
vitejs:mainfrom
sapphi-red:chore/update-miniflare

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

Description

We were stuck with miniflare v1 because miniflare v2+ only supported Node.js 16.7+.
This PR updates miniflare to v3.

This PR requires #14030 otherwise the Node.js 14 test will fail.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added dependencies Pull requests that update a dependency file p1-chore Doesn't change code behavior (priority) labels Aug 15, 2023
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red added this to the 5.0 milestone Aug 15, 2023
@sapphi-red sapphi-red force-pushed the chore/update-miniflare branch from 8c91233 to 67e3278 Compare August 16, 2023 02:26
@sapphi-red sapphi-red marked this pull request as ready for review August 16, 2023 02:26
@sapphi-red
Copy link
Copy Markdown
Member Author

Rebased on main to make the tests pass.

@bluwy bluwy merged commit 7f302bc into vitejs:main Aug 21, 2023
@sapphi-red sapphi-red deleted the chore/update-miniflare branch August 21, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file p1-chore Doesn't change code behavior (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants