feat: backport mdx as known js source (#14560) #14670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mark Dalgleish <[email protected]>
patak-dev
added
the
p2-nice-to-have
sapphi-red
approved these changes
Oct 17, 2023
Member
sapphi-red
left a comment
sapphi-red
left a comment
There was a problem hiding this comment.
I think it should be fine as importing MDX file returned an URL to the raw MDX file , which doesn't have usecases I guess. For normal use cases, I believe plugin-react-pages's test would cover it.
bluwy
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #14560
What is the purpose of this pull request?