Skip to content

fix(ssrTransform): handle arbitrary module namespace identifiers #17446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

gtm-nayan
Copy link
Contributor

Description

fix #17426

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

bluwy
bluwy previously approved these changes Jun 12, 2024
Copy link

pkg-pr-new bot commented Jun 12, 2024

vite (5e8734c)

npm i https://pkg.pr.new/vite@17446

@hi-ogawa
Copy link
Collaborator

I only mentioned the "export" side but it probably needs to handle "import" side too?

For example, this has ImportSpecifier.imported: Literal but @types/estree currently assumes Identifier.
https://astexplorer.net/#/gist/2e02b34a95dbb538a77451fedfd69f63/bbd2554c57078b89f678883c89b9a38625dfe6a5

@gtm-nayan
Copy link
Contributor Author

fixed, thanks

@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on f8a689c: Open

suite result latest scheduled
histoire success failure
nuxt failure failure
vite-plugin-react-pages failure failure
vite-setup-catalogue failure failure
vitest failure failure

analogjs, astro, ladle, laravel, marko, previewjs, quasar, qwik, rakkas, remix, sveltekit, unocss, vike, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vitepress

@bluwy bluwy merged commit 0a76652 into vitejs:main Jun 13, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite SSR doesn't support "Arbitrary Module Namespace Identifiers"
5 participants