Skip to content

fix(worker): nested inlined worker always fallbacked to data URI worker instead of using blob worker#17509

Merged
patak-cat merged 2 commits into
vitejs:mainfrom
hughfenghen:fix/worker-origin-null
Jul 13, 2024
Merged

fix(worker): nested inlined worker always fallbacked to data URI worker instead of using blob worker#17509
patak-cat merged 2 commits into
vitejs:mainfrom
hughfenghen:fix/worker-origin-null

Conversation

@hughfenghen

Copy link
Copy Markdown
Contributor

Description

fix #17507

Creating a WebWorker inside a WebWorker will the self.origin value being null.
Beacause WebWorker was created using a Data URL.

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Comment thread packages/vite/src/node/plugins/worker.ts
@sapphi-red sapphi-red added feat: web workers p3-minor-bug An edge case that only affects very specific usage (priority) labels Jul 6, 2024
@sapphi-red sapphi-red changed the title fix(plugins): self.origin value may be null in a WebWorker. fix(worker): nested inlined worker always fallbacked to data URI worker instead of using blob worker Jul 10, 2024
@patak-cat patak-cat merged commit 07bc489 into vitejs:main Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: web workers p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating a WebWorker inside a WebWorker will the self.origin value being null.

3 participants