Skip to content

fix: use shared sigterm callback #19203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patak-cat merged 1 commit into from
Jan 14, 2025
Merged

fix: use shared sigterm callback #19203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions packages/vite/src/node/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1535,20 +1535,34 @@ export function partialEncodeURIPath(uri: string): string {
return filePath.replaceAll('%', '%25') + postfix
}

type SigtermCallback = (signal?: 'SIGTERM', exitCode?: number) => Promise<void>

// Use a shared callback when attaching sigterm listeners to avoid `MaxListenersExceededWarning`
const sigtermCallbacks = new Set<SigtermCallback>()
const parentSigtermCallback: SigtermCallback = async (signal, exitCode) => {
await Promise.all([...sigtermCallbacks].map((cb) => cb(signal, exitCode)))
}

export const setupSIGTERMListener = (
callback: (signal?: 'SIGTERM', exitCode?: number) => Promise<void>,
): void => {
process.once('SIGTERM', callback)
if (process.env.CI !== 'true') {
process.stdin.on('end', callback)
if (sigtermCallbacks.size === 0) {
process.once('SIGTERM', parentSigtermCallback)
if (process.env.CI !== 'true') {
process.stdin.on('end', parentSigtermCallback)
}
}
sigtermCallbacks.add(callback)
}

export const teardownSIGTERMListener = (
callback: Parameters<typeof setupSIGTERMListener>[0],
): void => {
process.off('SIGTERM', callback)
if (process.env.CI !== 'true') {
process.stdin.off('end', callback)
sigtermCallbacks.delete(callback)
if (sigtermCallbacks.size === 0) {
process.off('SIGTERM', parentSigtermCallback)
if (process.env.CI !== 'true') {
process.stdin.off('end', parentSigtermCallback)
}
}
}