docs(create-vite): recommend eslint-react for linting#19524
Conversation
sapphi-red
left a comment
There was a problem hiding this comment.
Personally, I feel using extends is better here as I won't come up with questions like "why does one code block uses extends and the other block doesn't". But I think the current state is fine as well 👍
ArnaudBarre
left a comment
There was a problem hiding this comment.
I'm fine with both approaches
|
Ok let's keep with the current change here for now then and we can see later if people feel it's confusing. |
|
Here, we can wait for this rfc to land on end user and |
|
@bluwy But |
|
Can you show that? I don't see it implemented still. The change to track is at eslint/eslint#19116 |
|
Sorry, you are right. It is only implemented in |
Description
Followup of #19514.
I made the simplest change possible in this PR, but alternatively we can also:
extends: [reactX.configs['recommended-typescript'], reactDom.configs.recommended]@eslint-react/eslint-pluginas a whole.I don't know if there's a best practice here, but personally for me I think it's easiest with no2 and let users setup as documented themselves. We can also link the type-aware setup above to https://typescript-eslint.io/getting-started/typed-linting so we don't have to maintain instructions anymore.
Also, I've tested the setup locally and it works.