feat(create-vite): scaffold with rolldown-vite#20739
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
bluwy
left a comment
bluwy
left a comment
There was a problem hiding this comment.
Maybe we can also briefly mention at the docs that they can use create-vite to try rolldown too.
| if (useRolldownVite) { | ||
| // renovate: datasource=npm depName=rolldown-vite | ||
| const rolldownViteVersion = '7.1.12' | ||
| const pkgVersion = `npm:rolldown-vite@${rolldownViteVersion}` |
There was a problem hiding this comment.
| const pkgVersion = `npm:rolldown-vite@${rolldownViteVersion}` | |
| const pkgVersion = `npm:rolldown-vite@^${rolldownViteVersion}` |
Should we use a caret here so it's not pinned? (I think it works but haven't tested)
There was a problem hiding this comment.
I'll prefer to keep without it as rolldown-vite doesn't necessarily follow semver.
There was a problem hiding this comment.
Alright. In that case, maybe the docs should also mention pinning to a version, but I'm happy to handle that separately.
There was a problem hiding this comment.
Like this section?
https://vite.dev/guide/rolldown.html#versioning-policy
There was a problem hiding this comment.
or do you mean updating the package.json example?
There was a problem hiding this comment.
Yeah I mean the docs mentioning "npm:rolldown-vite@latest", so it's also not pinned to a specific version. It could mention that it's recommended to specify a specific version instead of latest.
3 participants
Description
Added a prompt to use rolldown-vite so that the exposure of rolldown-vite increases a bit more.