fix: shortcuts not rebound after server restart #21166
Merged
+53
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
reviewed
Dec 1, 2025
| // Restart the server | ||
| action.mockClear() | ||
| await server.restart() | ||
|
|
Member
There was a problem hiding this comment.
I was not expecting the binding state to be preserved across the server restart (i.e. I was thinking that bindCLIShortcuts should be called at this line as well). But it seems that behavior exists since the beginning #13675 and I guess it's fine to keep it as-is.
sapphi-red
added
p3-minor-bug
sapphi-red
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression from #21103 where shortcuts stop working after
server.restart().When the dev server restarts, the readline interface is preserved in the new server but it stops responding to input as it has been closed when the old server was closed. This clears the closed readline reference so a fresh instance will be created.