Skip to content

fix: type error by #3151 #3292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2021
Merged

fix: type error by #3151 #3292

merged 2 commits into from
May 7, 2021

Conversation

antfu
Copy link
Member

@antfu antfu commented May 7, 2021

Description

Fix build failing in introduced in #3151 (implicit merging conflict)

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu merged commit fd4146b into vitejs:main May 7, 2021
@antfu antfu deleted the fix/3151-conflict branch May 7, 2021 08:15
fi3ework pushed a commit to fi3ework/vite that referenced this pull request May 22, 2021
@antfu @fi3ework
fix: type error by vitejs#3151 (vitejs#3292)
56a7a75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antfu @patak-dev