Skip to content

fix(create-vite): project name with only numbers as an argument #4606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patak-cat merged 3 commits into from
Aug 18, 2021
Merged

fix(create-vite): project name with only numbers as an argument #4606

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98af613
fix: add options for minimist because number argument is treated as n…
task4233 Aug 15, 2021
c596a24
feat: add comment for helping an user to understand the second argume…
task4233 Aug 16, 2021
d09e8e5
change: update message for user understanding a lot
task4233 Aug 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/create-vite/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
// @ts-check
const fs = require('fs')
const path = require('path')
const argv = require('minimist')(process.argv.slice(2))
// Avoids autoconversion to number of the project name by defining that the args
// non associated with an option ( _ ) needs to be parsed as a string. See #4606
const argv = require('minimist')(process.argv.slice(2), { string: ['_'] })

@antfu antfu Aug 15, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found it's hard to understand what's going on. We'd better add a comment for that, or just use toString() on usage.

@task4233 task4233 Aug 16, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antfu
Thanks for your comment!

I agree with it's hard to undarstand what's going on. So, I've added a comment for that.
Could you review that?

Thanks.

// eslint-disable-next-line node/no-restricted-require
const prompts = require('prompts')
const {
Expand Down