Skip to content

perf: bundle create-vite#9034

Merged
patak-cat merged 6 commits into
vitejs:mainfrom
sapphi-red:perf/bundle-create-vite
Aug 29, 2022
Merged

perf: bundle create-vite#9034
patak-cat merged 6 commits into
vitejs:mainfrom
sapphi-red:perf/bundle-create-vite

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

@sapphi-red sapphi-red commented Jul 11, 2022 •
edited
Loading

Description

Bundles and minifies create-vite to reduce download time and requests.

before after diff
create-vite gz 24,009B 39,043B
total gz 119,108B 39,043B -80,065B (-67.2%)
node_modules 468,791B 174,294B -294,497B (-62.8%)

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Jul 11, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 11, 2022 •
edited
Loading

✅ Deploy Preview for vite-docs-main ready!

Name Link
🔨 Latest commit 480057e
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62cc3d751c28000009993edb
😎 Deploy Preview https://deploy-preview-9034--vite-docs-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sapphi-red
sapphi-red commented Jul 11, 2022
View reviewed changes
Comment thread scripts/rollupLicensePlugin.mjs
@@ -0,0 +1,126 @@
// @ts-check
Copy link
Copy Markdown
Member Author

@sapphi-red sapphi-red Jul 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file needs to be js because it is imported from packages/vite/rollup.plugin.ts and it won't be transpiled.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 11, 2022 •
edited
Loading

✅ Deploy Preview for vite-docs-main ready!

Name Link
🔨 Latest commit af67914
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62cc3e357af2c00008b5c469
😎 Deploy Preview https://deploy-preview-9034--vite-docs-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bluwy
bluwy previously approved these changes Jul 14, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Was hoping git would detect as a move instead so we get to preserve the git history for the index.js, but I don't think that's a big issue.

@sapphi-red sapphi-red mentioned this pull request Aug 2, 2022
Merged
9 tasks
@patak-cat
Copy link
Copy Markdown
Member

patak-cat commented Aug 25, 2022

@sapphi-red would you resolve the conflicts when you have a chance? I think we could release this in tandem with the next Vite minor (as a new create-vite minor)

@sapphi-red
Copy link
Copy Markdown
Member Author

sapphi-red commented Aug 26, 2022

@patak-dev Which should I rebase on, main or #9406?

@patak-cat
Copy link
Copy Markdown
Member

patak-cat commented Aug 26, 2022

@sapphi-red mmm... let's wait for today's meeting, we may have a decision about #9406 then.

@bluwy
Copy link
Copy Markdown
Member

bluwy commented Aug 28, 2022

Looks like #9406 is merged, so this can be rebased on main now

@sapphi-red sapphi-red force-pushed the perf/bundle-create-vite branch from af67914 to 02caedf Compare August 28, 2022 11:08
@sapphi-red sapphi-red marked this pull request as draft August 28, 2022 11:09
@sapphi-red sapphi-red force-pushed the perf/bundle-create-vite branch from 02caedf to c785eec Compare August 28, 2022 11:25
@sapphi-red sapphi-red force-pushed the perf/bundle-create-vite branch from c785eec to fb49a3b Compare August 28, 2022 11:42
@sapphi-red sapphi-red marked this pull request as ready for review August 28, 2022 11:46
@sapphi-red
Copy link
Copy Markdown
Member Author

sapphi-red commented Aug 28, 2022

I've rebased on main 👍

@sapphi-red sapphi-red requested review from bluwy and patak-cat August 28, 2022 11:59
@patak-cat patak-cat merged commit 37ac91e into vitejs:main Aug 29, 2022
@sapphi-red sapphi-red deleted the perf/bundle-create-vite branch August 30, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-cat patak-cat patak-cat approved these changes

@bluwy bluwy Awaiting requested review from bluwy

Assignees

No one assigned

Labels

p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sapphi-red @patak-cat @bluwy