chore: fix and enhance/align workflows #795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paescuj
force-pushed
the
chore/fix-and-enhance-workflows
branch
from
8be7b58 to
b46c3da
Compare
paescuj
force-pushed
the
chore/fix-and-enhance-workflows
branch
from
b46c3da to
2604b6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might fix #791; I guess the workflow stopped working because the GITHUB_TOKEN 1 no longer has any write permissions by default. Explicitly granting write permissions on
contentsensures it can create GitHub releases again. Write permissions on contents implies read permissions, so I'd assume this should also be sufficient to get the necessary data to generate the changelog.The steps to setup the env (Node.js and pnpm) are now consolidated in a "setup" action.
The current main/dev version of Node.js is now defined via the
.node-versionfile which is used by the action as the default version. This file is also respected by some Node.js version managers.In the CI workflow, the Node.js and OS matrix values are now correctly passed on (previously had no effect).
The actions are updated to their latest versions.
The PR also contains some semantic/stylistic alignments, like naming all jobs and steps.
Lastly, I've changed the file extensions from
ymltoyaml, which is a personal preference, e.g. for consistency with the pnpm config files. Let me know if you preferymlthough, and I'll revert that. And of course, if you dislike any other changes or prefer to have the changes split across multiple PRs.Footnotes
https://docs.github.com/en/actions/tutorials/authenticate-with-github_token#modifying-the-permissions-for-the-github_token ↩