chore!: update vite@5 and rollup@4 by Dunqing · Pull Request #4368 · vitest-dev/vitest

Dunqing · 2023-10-25T03:23:45Z

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

Run the tests with pnpm test:ci.

Documentation

If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

bolt-new-by-stackblitz · 2023-10-25T03:23:49Z

Run & review this pull request in StackBlitz Codeflow.

netlify · 2023-10-25T03:23:50Z

✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name	Link
🔨 Latest commit	`56284cf`
🔍 Latest deploy log	https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/654cf3edc745dc0008a0e94e

sheremet-va · 2023-10-29T20:57:22Z

I want to merge this, but PR has merge conflicts. @Dunqing can you resolve them?

Dunqing · 2023-10-30T05:58:59Z

I want to merge this, but PR has merge conflicts. @Dunqing can you resolve them?

Sure!

Dunqing · 2023-11-01T11:03:18Z

I roughly compared the ci test time between this branch and the main branch, and the testing time seems to have decreased 😀

sheremet-va · 2023-11-01T11:22:18Z

We should wait for vitejs/vite#14833 to be released, so we can import parseAstAsync from vite directly

Dunqing · 2023-11-01T11:30:44Z

We should wait for vitejs/vite#14833 to be released, so we can import parseAstAsync from vite directly

Should we specify version 5 for vite, otherwise we don't have parseAst

sheremet-va · 2023-11-01T11:46:05Z

We should wait for vitejs/vite#14833 to be released, so we can import parseAstAsync from vite directly

Should we specify version 5 for vite, otherwise we don't have parseAst

Yep

gajus · 2023-11-01T18:33:14Z

FYI Vite released the changes.

Thank you for this PR @Dunqing

sheremet-va · 2023-11-02T14:09:29Z

Interesting errors in your tests 🤔

Dunqing · 2023-11-02T14:37:56Z

Interesting errors in your tests 🤔

Looking good now.

Recent tests seem to have some unusual errors, and not just in this branch.

gajus · 2023-11-02T18:24:34Z

@sheremet-va Is there anything else that needs to be done here?

ghiscoding · 2023-11-03T22:07:30Z

Vite is now at 5.0.0-beta.16, does this PR need another update? It looks like Vite is getting closer to a release since a PR for Vite 5 announcement blog post was created. I guess that Vitest is not quite ready for the official 1.0 yet, right? From the Vitest 1.0 roadmap, it looks like migrating vite-node into Vite is the biggest task left but I assume this might not happen right away since Vite 5 is very close to be shipped?

Thanks for the great work 🎉

sheremet-va · 2023-11-04T09:36:19Z

vite-node will not be in Vite 5, yes.

not sure what update this PR needs tho, can you elaborate?

ghiscoding · 2023-11-04T16:56:10Z

vite-node will not be in Vite 5, yes.

not sure what update this PR needs tho, can you elaborate?

just an update from Vite Beta.15 to Beta.17, nothing else

This took a bit of figuring out. The process was: - Add `.npmrc` to this repo per: - https://pnpm.io/npmrc#auto-install-peers - https://pnpm.io/npmrc#prefer-frozen-lockfile - https://pnpm.io/npmrc#prefer-workspace-packages - `git clone https://github.com/vitest-dev/vitest.git` in the parent directory of this repository. - Add 'file:' dependencies to vitest and @vitest/browser, both residing within '../vitest/packages'. https://pnpm.io/cli/link#whats-the-difference-between-pnpm-link-and-using-the-file-protocol - Add pnpm-workspace.yaml with an '../vitest/packages/*' entry so the local vitest modules can find their peer modules in the same workspace. https://pnpm.io/pnpm-workspace_yaml - Set vite to 4.5.1, since I eventually learned the problem always occurs with vite 5.0.5. (I suspect this may have something to do with the upgrade from Rollup 4 to Rollup 5.) Then in the `../vitest` directory: ```sh git reset --hard v1.0.0-beta.4 pnpm i --ignore-scripts --frozen-lockfile pnpm build ``` And back in this repository: ```sh pnpm i pnpm test ``` I can now get the demo test running successfully against the local vitest v1.0.0-beta.4. Repeating the process for v1.0.0-beta.5, I can reproduce the vitest/utils import problem/reload loop. Now let's see what a `git bisect` will produce... ...one thing I already noticed: - The vitest packages from v1.0.0-beta.4 depend on vite < 5.0.0 - The vitest packages from v1.0.0-beta.5 depend on vite >= 5.0.0-beta* So...could be the issue resides within Vite somehow. The vitest repo is OK up through this commit, which is the last working commit before the Vite ^5.0.0 bump: - commit f6a445dbc86e0e5b7de29ae650ecebf8ac6e4ffa The next commit breaks the pnpm-lock.yaml file, and remains broken until the following commit and the PR containing it gets merged: - commit 5b738663197b78cf103b269c6e7489286957c1a7 - vitest-dev/vitest#4368 ```sh git diff f6a445dbc86e0e5b7de29ae650ecebf8ac6e4ffa 5b738663197b78cf103b269c6e7489286957c1a7 ``` Yep. None of the changes there seem to have anything directly to do with packages/browser/src/client/main.ts or the `config.base` value. It seems to be the Vite 5 upgrade, which is consistent with the fact that v1.0.0-beta.4 works with Vite 4.5.1, but not Vite 5.0.5. Now that I've got my methodology down, next I'll start bisecting commits in Vite.

sheremet-va requested changes Oct 27, 2023

View reviewed changes

Comment thread packages/vitest/LICENSE.md Outdated

sheremet-va mentioned this pull request Oct 29, 2023

TypeScript error when using Yarn PnP #4391

Closed

6 tasks

sheremet-va requested changes Oct 30, 2023

View reviewed changes

Comment thread packages/vitest/rollup.config.js Outdated

Comment thread packages/vitest/rollup.config.js Outdated

Comment thread packages/vitest/rollup.config.js Outdated

Comment thread packages/vitest/package.json Outdated

Dunqing force-pushed the chore/rollup4 branch 2 times, most recently from e7cdf7a to 3523a6a Compare November 1, 2023 07:58

sheremet-va reviewed Nov 1, 2023

View reviewed changes

Comment thread packages/vite-node/src/externalize.ts Outdated

sheremet-va reviewed Nov 1, 2023

View reviewed changes

Comment thread packages/vite-node/src/server.ts

Dunqing changed the title ~~chore: upgrade to rollup 4~~ chore!: update vite@5 and rollup@4 Nov 2, 2023

sheremet-va reviewed Nov 2, 2023

View reviewed changes

Comment thread packages/vitest/package.json Outdated

Dunqing added 6 commits November 9, 2023 15:21

chore: upgrade to rollup 4

a86855a

chore: update dep

72dce68

chore: remove acorn, upgrade vite to beta

3c6e4a5

fix: type error

bbb0f45

chore: update license

2262b6d

chore: external rollup/parseAst

0456b53

Dunqing and others added 22 commits November 9, 2023 15:22

fix: mlly

c682133

feat: store parseAst from plugin

9731f1f

fix: avoid re-assign

e418d61

perf: remove isValidNodeImport

b3ee1ef

perf: remove mlly

8c53f8c

feat: inline isValidNodeImport

518a6ea

fix: lock

0838046

fix: remove protocol

10fe82a

perf: fix

4fe1e31

feat: should externalize

c5223a5

feat: port findNearestPackageData, remove pkg-types

59fe569

fix: remove processed logic

774d3d3

chore: update deps

6ee7a99

chore: use parseAstAsync instead

b233bd4

fix: remove ParseStorePlugin

60eaa4b

chore: update version

e561708

chore: add type: module, remove old examples

da18821

chore: update package.json

b677218

chore: change extensions

a2f9b4b

test: update coverage snapshot

f9c946b

chore: update vite requirements in docs and readnme

e3e6803

chore: cleanup

9d59478

sheremet-va force-pushed the chore/rollup4 branch from e40b952 to 9d59478 Compare November 9, 2023 14:24

sheremet-va added 3 commits November 9, 2023 15:32

chore: cleanup

075729a

chore: remove puppeteer

60b128f

chore: remove PUPPETEER_VERSION

56284cf

sheremet-va merged commit a2d7565 into vitest-dev:main Nov 10, 2023

mbland mentioned this pull request Dec 6, 2023

unhandled error with browser tests and modified base #4686

Closed

6 tasks

hi-ogawa mentioned this pull request Mar 22, 2024

Imported dependency file executed twice #5404

Closed

6 tasks

Uh oh!

Conversation

Dunqing commented Oct 25, 2023

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Documentation

Changesets

Uh oh!

bolt-new-by-stackblitz Bot commented Oct 25, 2023

Uh oh!

netlify Bot commented Oct 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.

Uh oh!

Uh oh!

sheremet-va commented Oct 29, 2023

Uh oh!

Dunqing commented Oct 30, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dunqing commented Nov 1, 2023

Uh oh!

sheremet-va commented Nov 1, 2023

Uh oh!

Dunqing commented Nov 1, 2023

Uh oh!

sheremet-va commented Nov 1, 2023

Uh oh!

gajus commented Nov 1, 2023

Uh oh!

Uh oh!

sheremet-va commented Nov 2, 2023

Uh oh!

Dunqing commented Nov 2, 2023

Uh oh!

gajus commented Nov 2, 2023

Uh oh!

ghiscoding commented Nov 3, 2023

Uh oh!

sheremet-va commented Nov 4, 2023

Uh oh!

ghiscoding commented Nov 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

netlify Bot commented Oct 25, 2023 •

edited

Loading

ghiscoding commented Nov 4, 2023 •

edited

Loading