Skip to content

fix(example): resolve type error#4515

Merged
sheremet-va merged 1 commit intovitest-dev:mainfrom
jqkk:main
Nov 16, 2023
Merged

fix(example): resolve type error#4515
sheremet-va merged 1 commit intovitest-dev:mainfrom
jqkk:main

Conversation

@jqkk
Copy link
Contributor

@jqkk jqkk commented Nov 16, 2023

Description

A type error occurs in the examples using testing-library. According to @testing-library/jsdom, We need to make additional settings in tsconfig.json. So I add it.

Problem situation

screenshot

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants